Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nav Unification: Update masterbar #45467

Merged
merged 11 commits into from
Sep 11, 2020
Merged

Nav Unification: Update masterbar #45467

merged 11 commits into from
Sep 11, 2020

Conversation

frontdevde
Copy link
Contributor

@frontdevde frontdevde commented Sep 8, 2020 •
edited
Loading

Changes proposed in this Pull Request

This is PR is a first step towards implementing the changes to the masterbar suggested in #45393.

Screenshots

Current PR state compared to wp-admin (in code-D49342):

masterbar)

Notes

This is a prototype and it's hidden behind a feature flag. We'll continue iterating on it.

As the prototype uses an additional class for scoping some styles of other masterbar states like support session and jetpack will be overridden due to the increased specificity. This is expected for this prototype.

When Calypso loads you'll see an initial flash of the app shell with the old nav styles. This is because we're using a feature flag to attach a class to the layout that gets processed once the client side JS kicks in. Once we move the styles to be the default, the app shell will look like the unified masterbar.

Testing instructions

This is behind a feature flag so we can iterate on it. Testing should mainly ensure something isn't fundamentally broken.

@frontdevde frontdevde added [Status] In Progress [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. labels Sep 8, 2020
@frontdevde frontdevde self-assigned this Sep 8, 2020
@matticbot
Copy link
Contributor

Test live: https://calypso.live/?branch=update/nav-unification-masterbar

@matticbot
Copy link
Contributor

matticbot commented Sep 8, 2020 •
edited
Loading

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~23 bytes added 📈 [gzipped])

name        parsed_size           gzip_size
entry-main        +54 B  (+0.0%)      +23 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@frontdevde frontdevde force-pushed the update/nav-unification-masterbar branch 2 times, most recently from 0bd0783 to 31e5dbe Compare September 9, 2020 12:26
@frontdevde frontdevde marked this pull request as ready for review September 10, 2020 15:47
@frontdevde frontdevde added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. and removed [Status] In Progress labels Sep 10, 2020
@frontdevde frontdevde changed the title [WIP] Nav Unification: Update masterbar Nav Unification: Update masterbar Sep 10, 2020
@cpapazoglou cpapazoglou linked an issue Sep 11, 2020 that may be closed by this pull request
Nav Unification: Update Masterbar/Toolbar #45393
Closed
@cpapazoglou cpapazoglou self-requested a review September 11, 2020 09:49
@cpapazoglou
Copy link
Contributor

Deployed r213505-wpcom

@cpapazoglou cpapazoglou force-pushed the update/nav-unification-masterbar branch from 3685cea to 5dab1d5 Compare September 11, 2020 10:08
cpapazoglou
cpapazoglou approved these changes Sep 11, 2020
View reviewed changes
Copy link
Contributor

@cpapazoglou cpapazoglou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @frontdevde ! Especially the comments with the source files will be really useful!
I just added a box-shadow to the whole masterbar (as it appears in wp-admin).

Tested by test instructions and desktop viewports are identical when combined with D49342-code!
Mobile breakpoints are very close to wp-admin, let's figure out the menu and finalise them in an other PR.

LGTM!

@cpapazoglou cpapazoglou merged commit 99784ab into master Sep 11, 2020
@cpapazoglou cpapazoglou deleted the update/nav-unification-masterbar branch September 11, 2020 12:30
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpapazoglou cpapazoglou cpapazoglou approved these changes

Assignees

@frontdevde frontdevde

Labels
[Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nav Unification: Update Masterbar/Toolbar
3 participants
@frontdevde @matticbot @cpapazoglou